From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B133F469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 15 Oct 2020 23:54:27 +0300 (MSK)
Date: Thu, 15 Oct 2020 23:43:49 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20201015204349.GJ32659@tarantool.org>
References: <0a48783b74bcb4fbdb3ff6f3decc79bded564bec.1602663758.git.avtikhon@tarantool.org>
 <d24e5f9ff1d11ae46fae285bc59c322acef1a32b.1602663758.git.avtikhon@tarantool.org>
 <20201015141713.GE32659@tarantool.org>
 <20201015190045.GA243454@hpalx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201015190045.GA243454@hpalx>
Subject: Re: [Tarantool-patches] [PATCH v4 4/5] build: enable cmake in curl
	build
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sasha,

Thanks, I've checked the new version on the branch. LGTM.

On 15.10.20, Alexander V. Tikhonov wrote:
> Hi Igor, I've made all corrections as you suggested and checked all
> the new options set in cmake. Founf 3 new options which I've blocked
> in curl build:
> 
> +    list(APPEND LIBCURL_CMAKE_FLAGS "-DPICKY_COMPILER=OFF")
> +    list(APPEND LIBCURL_CMAKE_FLAGS "-DBUILD_CURL_EXE=OFF")
> +    list(APPEND LIBCURL_CMAKE_FLAGS "-DCURL_ZLIB=OFF")

Side note: Discussed this change offline, and there is no the last line
on the branch.

> 

<snipped>

-- 
Best regards,
IM