Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin <imun@tarantool.org>
To: Timur Safin <tsafin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, alexander.turenko@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] luajit - avoid hardcode of paths to luajit test
Date: Thu, 15 Oct 2020 23:41:36 +0300	[thread overview]
Message-ID: <20201015204136.GI32659@tarantool.org> (raw)
In-Reply-To: <11457da6c5f5f29b511a809cbc0908b19458d284.1602778378.git.tsafin@tarantool.org>


Thanks for your patch! It's worth to mention the fact we are working on
self-sufficient LuaJIT testing[1], so this mess will be gone in a while.

Please, consider the comments regarding your patch are below.

At first, CI is red[2], so unfortunately, the patch doesn't work...

Please adjust the commit subject consdering our guidelines[3]. I propose
the following: s/luajit -/test:/.

On 15.10.20, Timur Safin wrote:
> We try to avoid hardcode of paths to LuaJIT tests, which
> live in the 3rd party repository and might get updated
> without our notice.

Well, your approach definitely simplifies the maintenance, *but* the
patch is not related to th original problem we faced recently.

> - to simplify cmake code we introduce symlink inside of `test`
>   directory which is now pointing to `third_party/luajit/test`
>   subdirectory

I prefer the way the symlink to <small> tests is created. However, IIRC
such approach contradicts with <add_subdirectory> behaviour, since there
is not such path at the proper CMake stage. Feel free to correct me if
I'm wrong. It would be perfect, if the symlink to the test directory
can be created at the configuration step.

There is also another approach: we can add the root CMakeLists.txt in
the LuaJIT test directory to enclose all necessary activity there.
This one look much more CMake-way, doesn't it?

> - and we use `file(GLOB...)` statement now to propagate list
>   of all available test directories we found inside of luajit
>   submodule.
> Closes #5425
> ---
>  test/CMakeLists.txt | 14 +++++++++++---
>  test/luajit         |  1 +
>  2 files changed, 12 insertions(+), 3 deletions(-)
>  create mode 120000 test/luajit


> -- 
> 2.20.1

[1]: https://github.com/tarantool/tarantool/issues/4862
[2]: https://gitlab.com/tarantool/tarantool/-/pipelines/203157106
[3]: https://www.tarantool.io/en/doc/latest/dev_guide/developer_guidelines/#how-to-write-a-commit-message

Best regards,

      parent reply	other threads:[~2020-10-15 20:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 16:19 [Tarantool-patches] (no subject) Timur Safin
2020-10-15 16:26 ` Timur Safin
2020-10-15 20:41 ` Igor Munkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201015204136.GI32659@tarantool.org \
    --to=imun@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=tsafin@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] luajit - avoid hardcode of paths to luajit test' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox