From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 27D82469719 for ; Thu, 15 Oct 2020 15:33:52 +0300 (MSK) Date: Thu, 15 Oct 2020 15:23:14 +0300 From: Igor Munkin Message-ID: <20201015122314.GB32659@tarantool.org> References: <0a48783b74bcb4fbdb3ff6f3decc79bded564bec.1602663758.git.avtikhon@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0a48783b74bcb4fbdb3ff6f3decc79bded564bec.1602663758.git.avtikhon@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v1 1/5] curl: enable curl build with old cmake List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: tarantool-patches@dev.tarantool.org Sasha, Thanks for the patch! It would be better to either explicitly drop this line or change it to the valid one (e.g. specify 2.8 version as the least one, since it's provided by ancient distros), but I don't insist. This remark is minor, your fix is temporary and just works, so I don't want to block the patch further. LGTM. -- Best regards, IM