From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergos@tarantool.org>
Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 62F38469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 15 Oct 2020 12:04:27 +0300 (MSK)
Date: Thu, 15 Oct 2020 12:04:23 +0300
From: Sergey Ostanevich <sergos@tarantool.org>
Message-ID: <20201015090423.GG2885@tarantool.org>
References: <cover.1602694006.git.skaplun@tarantool.org>
 <098b637d1a67b7a0e8215d8d4cd9327b6a0e266c.1602694006.git.skaplun@tarantool.org>
 <20201014194310.GJ18920@tarantool.org> <20201015072537.GC9302@root>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20201015072537.GC9302@root>
Subject: Re: [Tarantool-patches] [PATCH 2/2] test: disable jit related tests
	at FreeBSD
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi!

Thanks for the patch!

LGTM.

Sergos

On 15 окт 10:25, Sergey Kaplun wrote:
> Hi, Igor! Thanks for the review!
> 
> I've updated commit message considering your comments and repushed
> branch.
> 
> On 14.10.20, Igor Munkin wrote:
> > Sergey,
> > 
> > Thanks for the patch! It LGTM, but I can't stop nitpicking :)
> > 
> > On 14.10.20, Sergey Kaplun wrote:
> > > This patch fixes the regression introduced in scope of
> > > 5a61e1ab54b5c66bfebd836db1ac47996611e065 ('misc: add C and Lua API for
> > > platform metrics').
> > > 
> > > As far as newly added tests include trace checks and
> > > https://github.com/tarantool/tarantool/issues/4819 (JIT fails to
> > 
> > Minor: Let's be consistent in referring external issues:
> > | tarantool/tarantool#4819
> > 
> > > allocate mcode memory on FreeBSD) has not resolved yet, this tests
> > 
> > Typo: s/this/these/.
> > 
> > > should be disabled to for running on FreeBSD.
> > 
> > Typo: s/to for/while/.
> > 
> > > 
> > > Follows up tarantool/tarantool#5187
> > > ---
> > 
> > <snipped>
> > 
> > > -- 
> > > 2.28.0
> > > 
> > 
> > -- 
> > Best regards,
> > IM
> 
> -- 
> Best regards,
> Sergey Kaplun