From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com
 [209.85.208.196])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 50733469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 15 Oct 2020 11:44:16 +0300 (MSK)
Received: by mail-lj1-f196.google.com with SMTP id f29so2322891ljo.3
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 15 Oct 2020 01:44:16 -0700 (PDT)
Date: Thu, 15 Oct 2020 11:44:13 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20201015084413.GC173841@grain>
References: <20201014142617.235813-1-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201014142617.235813-1-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH 0/2] raft: a few fixes
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: tml <tarantool-patches@dev.tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On Wed, Oct 14, 2020 at 05:26:15PM +0300, Cyrill Gorcunov wrote:
> Vlad, Sergey, here are a few nitpicks. Feel free to
> ignore just came to mind while been reading the code.
> 
> The issue with potential nil dereference for raft worker
> should be addressed separately on top of the Vlad fixes.

Forgot to mention it is gorcunov/raft-fixes branch