From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 93793469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 15 Oct 2020 05:35:27 +0300 (MSK)
Date: Thu, 15 Oct 2020 05:35:47 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20201015023547.c52bmidwkbom4rky@tkn_work_nb>
References: <cover.1602541394.git.alexander.turenko@tarantool.org>
 <6753bd0b7bc224dfb7634b2242075d4a164ff949.1602541394.git.alexander.turenko@tarantool.org>
 <d6eef08d-816a-f775-b2c3-6eba9dc27f04@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <d6eef08d-816a-f775-b2c3-6eba9dc27f04@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 08/16] module api/lua: add
 API_EXPORT to tuple functions
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Thu, Oct 15, 2020 at 01:41:53AM +0200, Vladislav Shpilevoy wrote:
> Thanks for the patch!
> 
> On 13.10.2020 01:23, Alexander Turenko wrote:
> > The reason is unification of declarations. It is the rule of thumb to
> > use API_EXPORT with module API functions.
> 
> What about box_tuple_ref, box_tuple_unref, box_tuple_field_count,
> and other tuple functions?

My motivation is to don't have mix of functions with and without
API_EXPORT after my changes. In the patchset I added new functions into
box/key_def and box/lua/tuple, so added the macro here. But I don't
touch box/tuple, so don't do any changes for consistency there.