From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2762C469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 15 Oct 2020 04:42:42 +0300 (MSK)
Date: Thu, 15 Oct 2020 01:42:41 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20201015014241.GC25221@tarantool.org>
References: <cover.1601729099.git.korablev@tarantool.org>
 <0a5e175c-aeb1-a847-ebca-ba5cdbaaca11@tarantool.org>
 <20201013101839.GA18306@tarantool.org>
 <6a552158-6152-10b8-7f86-47aa71923ed4@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <6a552158-6152-10b8-7f86-47aa71923ed4@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 0/2] vinyl: rework upsert
	operation
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 15 Oct 01:44, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
> 
> The test looks fine, but hard to extend. I would better try to
> organize a more extendible folder structure, like test/xlog/upgrade
> does. With the current 'flat' structure we will have problems with
> adding more tests for other versions in the future.
> 
> I see you already pushed it, so I am too late.

Np, I'll do it tomorrow as follow-up. I've also found that
vinyl/upgrade.test.lua is disabled and seems there's no corresponding
snap/vylog files to run this test at all..