From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A73E0469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 15 Oct 2020 02:04:17 +0300 (MSK)
Date: Thu, 15 Oct 2020 02:04:37 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20201014230437.zflzpujzknxompvs@tkn_work_nb>
References: <2a19304adfd3877d0fa26cde1d8d8c313a291588.1602677553.git.artemreyt@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2a19304adfd3877d0fa26cde1d8d8c313a291588.1602677553.git.artemreyt@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] luacheck: fixed warning in
	tarantoolctl.in
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Artem Starshov <artemreyt@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

LGTM.

Pushed to master and 2.5.

WBR, Alexander Turenko.

On Wed, Oct 14, 2020 at 03:14:08PM +0300, Artem Starshov wrote:
> luacheck: fixed warning in tarantoolctl.in

Nit: Use imperative mood in a commit header, 'fix' instead of 'fixed'.

> Changed passing global variable arg to function
> find_instance_name(arg) instead of passing arg[0] and arg[2] separately.
> And removed exception in .luacheckrc for file /extra/dist/tarantoolctl.in.

Nit: Fit the commit message body to 72 symbols (at least for a prose
text, but not necessary for listings and so).

> 
> This change only solves linter warning, nothing else.
> 
> Fixed #4929.

The commit message on the branch is the previous one. Next time, please,
keep a branch in sync with patches you send to the mailing list.