From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7475A469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 14 Oct 2020 22:58:37 +0300 (MSK)
Date: Wed, 14 Oct 2020 22:47:59 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20201014194759.GK18920@tarantool.org>
References: <cover.1602694006.git.skaplun@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1602694006.git.skaplun@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/2] Fix broken CI after introduced
	LuaJIT metrics
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

I believe it's a good practice to add the link with green CI for the
branch too. This is definitely not obligatory, but I guess it can help
to reduce the issues we fixed in scope of this patchset.

On 14.10.20, Sergey Kaplun wrote:
> This patch fixes the regressions introduced in scope of
> 5a61e1ab54b5c66bfebd836db1ac47996611e065 ('misc: add C and Lua API for
> platform metrics').
> 
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-5187-fix-tests-fails-ci
> This branch is rebased on Igor's branch:
> https://github.com/tarantool/luajit/tree/imun/gh-5187-fix-disp-encoding-on-gc64
> 
> CI: https://gitlab.com/tarantool/tarantool/-/pipelines/202569424/builds

You've already it here, great!

> Side note: failing CI at osx jobs related to this issue:
> https://github.com/tarantool/tarantool/issues/5423
> 
> Sergey Kaplun (2):
>   test: force enable assert checks in release build
>   test: disable jit related tests at FreeBSD
> 
>  test/misclib-getmetrics-capi.skipcond         | 7 +++++++
>  test/misclib-getmetrics-capi/testgetmetrics.c | 1 +
>  test/misclib-getmetrics-lapi.skipcond         | 7 +++++++
>  3 files changed, 15 insertions(+)
>  create mode 100644 test/misclib-getmetrics-capi.skipcond
>  create mode 100644 test/misclib-getmetrics-lapi.skipcond
> 
> -- 
> 2.28.0
> 

-- 
Best regards,
IM