From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BFD1A469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 14 Oct 2020 22:40:12 +0300 (MSK)
Date: Wed, 14 Oct 2020 22:29:35 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20201014192935.GH18920@tarantool.org>
References: <cover.1602694006.git.skaplun@tarantool.org>
 <d6caf3ced33ceb81113b91a65893fb6b935a0258.1602694006.git.skaplun@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <d6caf3ced33ceb81113b91a65893fb6b935a0258.1602694006.git.skaplun@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/2] test: force enable assert
	checks in release build
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sergey,

Thanks for the patch! Consider a couple nits below.

On 14.10.20, Sergey Kaplun wrote:
> This patch fixes the regression introduced in scope of
> 5a61e1ab54b5c66bfebd836db1ac47996611e065 ('misc: add C and Lua API for
> platform metrics'). As a result of the patch release build
> was failed according to -Werror compiler flag and unused variables that
> used only for assertions checks.
> 
> Force #undef NDEBUG directive leaves asserts on and allows not disable

Minor: IMHO "leaves asserts enabled, so the introduced tests works even
with release build" is a little better, but this doesn't change the
meaning, so feel free to ignore.

> newly added tests for release build.
> 
> Follows up tarantool/tarantool#5187
> ---
>  test/misclib-getmetrics-capi/testgetmetrics.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/misclib-getmetrics-capi/testgetmetrics.c b/test/misclib-getmetrics-capi/testgetmetrics.c
> index 8844b17..3b6f599 100644
> --- a/test/misclib-getmetrics-capi/testgetmetrics.c
> +++ b/test/misclib-getmetrics-capi/testgetmetrics.c
> @@ -4,6 +4,7 @@
>  
>  #include <lmisclib.h>
>  
> +#undef NDEBUG

Minor: It would be nice to drop a few words regarding this hack. At the
same time, the code is well-structured, so it's quite obvious that you
want asserts to be always enabled. Feel free to ignore.

>  #include <assert.h>
>  
>  static int base(lua_State *L)
> -- 
> 2.28.0
> 

-- 
Best regards,
IM