From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com
 [209.85.167.67])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BE95D469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 13 Oct 2020 17:01:59 +0300 (MSK)
Received: by mail-lf1-f67.google.com with SMTP id l2so22267248lfk.0
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 13 Oct 2020 07:01:59 -0700 (PDT)
Date: Tue, 13 Oct 2020 17:01:55 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20201013140155.GE14048@grain>
References: <20201013133418.34422-1-sergepetrenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201013133418.34422-1-sergepetrenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] feedback_daemon: add synchro
 replication usage reporting
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org

On Tue, Oct 13, 2020 at 04:34:18PM +0300, Serge Petrenko wrote:
>  
> +local function fill_in_options(feedback)
> +    local options = {}
> +    options.election_mode = box.cfg.election_mode
> +    options.synchro_quorum = box.cfg.replication_synchro_quorum
> +    feedback.options = options
> +end

Maybe be we could just get rid of local variable here?

local function fill_in_options(feedback)
    feedback.options = {
        ['election_mode']   = box.cfg.election_mode,
        ['synchro_quorum']  = box.cfg.replication_synchro_quorum,
    }
end

Not insisting at all just a thought.