From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C1986469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 13 Oct 2020 16:22:27 +0300 (MSK)
Date: Tue, 13 Oct 2020 16:22:26 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20201013132226.tifrxxxhbo5nc3ar@tarantool.org>
References: <20201013120239.29831-1-i.kosarev@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20201013120239.29831-1-i.kosarev@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4] key_def: support composite types
	extraction
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, alexander.turenko@tarantool.org

Hello,

On 13 окт 15:02, Ilya Kosarev wrote:
> key_def didn't support key definitions with array, map, varbinary & any
> fields. Thus they couldn't be extracted with
> key_def_object:extract_key(). Since the restriction existed due to
> impossibility of such types comparison, this patch removes the
> restriction for the fields extraction and only leaves it for
> comparison.
> 
> Closes #4538
> ---
> Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4538-key_def-extract-arrays
> Issue: https://github.com/tarantool/tarantool/issues/4538

I've checked your patch into master and added an entry to relase notes.

--
Regards, Kirill Yukhin