From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3BE6B469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 13 Oct 2020 16:17:35 +0300 (MSK)
Date: Tue, 13 Oct 2020 16:17:34 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20201013131734.cjb5uebe257z7rsl@tarantool.org>
References: <cover.1601878708.git.skaplun@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cover.1601878708.git.skaplun@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 0/2] Implement LuaJIT platform
 metrics
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 05 окт 09:30, Sergey Kaplun wrote:
> The series consists of 2 patches. The first one adds corresponding
> counters to LuaJIT internal structures. The second provides C and Lua
> API using this counters to collect metrics.
> 
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-5187-luajit-metrics
> Issue: https://github.com/tarantool/tarantool/issues/5187
> 
> Changes in v2:
> - Fixed naming and comments
> - Fixed padding in struct GCState
> - Dropped unnecessary initialisations inside lua_newstate()
> - Avoided flushing any of metrics after each call of luaM_metrics()
> 
> Changes in v3:
> - Cleaned up mess in Makefile.dep
> - Fixed naming and comments
> - Fixed padding in struct GCState for 64-bit architectures
> - Fixed counting amount of JIT traces
> - Fixed objects counting at trace recording
> - Added counting of colors
> - Added C and Lua tests
> 
> Changes in v4:
> - Removed counting of colors
> - Changed global_State structure correspondingly for 32-bit arm build
> 
> Sergey Kaplun (2):
>   core: introduce various platform metrics
>   misc: add C and Lua API for platform metrics

I've checked your patchset into tarantool branch of luajit repo and
bumped a new version in 1.10, 2.4, 2.5 and master.

--
Regards, Kirill Yukhin