From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [94.100.177.91])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 85998469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 13 Oct 2020 16:09:33 +0300 (MSK)
Date: Tue, 13 Oct 2020 16:09:31 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20201013130931.GA826336@hpalx>
References: <20201012120904.93757-1-sergepetrenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201012120904.93757-1-sergepetrenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] test: merge possilbe failed test
 outputs for election_qsync
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi Sergey, thanks for the fast fix. I've checked the patch and it helped
to use checksums on fails of this test. Patch LGTM.

On Mon, Oct 12, 2020 at 03:09:04PM +0300, Serge Petrenko wrote:
> Instead of having all possible 2^10 diffs in case select{} fails,
> log the select{} output in case the space contains less than 10
> elements.
> Requested by @avtikhon for easier flaky test handling.
> 
> Related to #5395
> ---
> https://github.com/tarantool/tarantool/issues/5395
> https://github.com/tarantool/tarantool/tree/sp/gh-5395-minimize-test-output
> 
>  test/replication/election_qsync.result   | 15 +++------------
>  test/replication/election_qsync.test.lua |  2 +-
>  2 files changed, 4 insertions(+), 13 deletions(-)
> 
> diff --git a/test/replication/election_qsync.result b/test/replication/election_qsync.result
> index 9497b37bf..09a76c51c 100644
> --- a/test/replication/election_qsync.result
> +++ b/test/replication/election_qsync.result
> @@ -109,18 +109,9 @@ test_run:cmd('setopt delimiter ""');
>   | - true
>   | ...
>  -- We're connected to some leader.
> -c.space.test:select{}
> - | ---
> - | - - [1]
> - |   - [2]
> - |   - [3]
> - |   - [4]
> - |   - [5]
> - |   - [6]
> - |   - [7]
> - |   - [8]
> - |   - [9]
> - |   - [10]
> +#c.space.test:select{} == 10 or require('log').error(c.space.test:select{})
> + | ---
> + | - true
>   | ...
>  
>  test_run:drop_cluster(SERVERS)
> diff --git a/test/replication/election_qsync.test.lua b/test/replication/election_qsync.test.lua
> index bca1b20c7..f84ca8440 100644
> --- a/test/replication/election_qsync.test.lua
> +++ b/test/replication/election_qsync.test.lua
> @@ -68,6 +68,6 @@ for i = 1,10 do
>  end;
>  test_run:cmd('setopt delimiter ""');
>  -- We're connected to some leader.
> -c.space.test:select{}
> +#c.space.test:select{} == 10 or require('log').error(c.space.test:select{})
>  
>  test_run:drop_cluster(SERVERS)
> -- 
> 2.24.3 (Apple Git-128)
>