From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <skaplun@tarantool.org>
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 97340469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 13 Oct 2020 09:01:50 +0300 (MSK)
Date: Tue, 13 Oct 2020 09:01:21 +0300
From: Sergey Kaplun <skaplun@tarantool.org>
Message-ID: <20201013060121.GA3103@root>
References: <cover.1601878708.git.skaplun@tarantool.org>
 <87bf84f266e16cd9401394c8276b1cd97f91a82d.1601878708.git.skaplun@tarantool.org>
 <20201009144507.GC2885@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20201009144507.GC2885@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 2/2] misc: add C and Lua API for
	platform metrics
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi, Sergos! Thanks for the review!

On 09.10.20, Sergey Ostanevich wrote:
> Hi!
> 
> Thanks for the patch!
> 
> I think it introduces a new user-visible interface, so we need a 
> @TarantoolBot document entry here?

I've created ticket here [1].

> 
> Otherwise LGTM.
> 
> Sergos
> 
> 
> On 05 окт 09:30, Sergey Kaplun wrote:

<snipped>

> > -- 
> > 2.28.0
> > 

[1]: https://github.com/tarantool/doc/issues/1597

-- 
Best regards,
Sergey Kaplun