From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id F0032469719
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 11 Oct 2020 21:19:27 +0300 (MSK)
Date: Sun, 11 Oct 2020 21:08:50 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20201011180850.GY18920@tarantool.org>
References: <cover.1602420460.git.alexander.turenko@tarantool.org>
 <e8afad701131cb592e113abf83ca83f5bd12cfc6.1602420460.git.alexander.turenko@tarantool.org>
 <20201011174755.GX18920@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201011174755.GX18920@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 05/15] lua: don't raise a Lua
 error from luaT_tuple_new()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Well, I looked to the sources once more :)

On 11.10.20, Igor Munkin wrote:
> Sasha,
> 
> It is not full review, but Vlad asked me offline regarding a passage
> below. So I dump our discussion results.
> 
> On 11.10.20, Alexander Turenko wrote:
> 
> <snipped>
> 
> > +	int top = lua_gettop(L);
> 
> This value can't be used, since <lua_rawgeti> can trigger Lua stack
> reallocation, ergo this value will be invalidated.

This is not the address, but offset, so nevermind.

> 
> > +
> > +	/* Calculate absolute value in the stack. */
> 

<snipped>

> 
> > -- 
> > 2.25.0
> > 
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
IM