From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 02194469719
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 10 Oct 2020 04:21:05 +0300 (MSK)
Date: Sat, 10 Oct 2020 04:21:22 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20201010012122.7iyb46eeruec4f6i@tkn_work_nb>
References: <cover.1600817803.git.alexander.turenko@tarantool.org>
 <c89c9a8c647943bff138f980fcd44ca7bc96bd25.1600817803.git.alexander.turenko@tarantool.org>
 <63b3b359-b18a-171b-cdcb-01a9f2db41f4@tarantool.org>
 <20201009011423.s5yygpmi5optobls@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201009011423.s5yygpmi5optobls@tkn_work_nb>
Subject: Re: [Tarantool-patches] [PATCH 13/14] WIP: module api: expose
 box_tuple_extract_key_ex()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Fri, Oct 09, 2020 at 04:14:23AM +0300, Alexander Turenko wrote:
> On Sat, Sep 26, 2020 at 12:58:27AM +0200, Vladislav Shpilevoy wrote:
> > Thanks for the patch!
> > 
> > Or instead of _ex you could make it a method of key_def and
> > call it box_key_def_extract_key(...). IMO that would be more
> > appropriate as a key_def method.
> 
> Since more questions about functions naming arose, I put my thoughts to
> [1].
> 
> [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-October/019989.html

It seems, we agreed on box_key_def_extract_key(). See [2] for details.

[2]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-October/020013.html