From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com
[209.85.167.67])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by dev.tarantool.org (Postfix) with ESMTPS id 6E24D44643D
for <tarantool-patches@dev.tarantool.org>;
Fri, 9 Oct 2020 00:36:48 +0300 (MSK)
Received: by mail-lf1-f67.google.com with SMTP id r127so8293765lff.12
for <tarantool-patches@dev.tarantool.org>;
Thu, 08 Oct 2020 14:36:48 -0700 (PDT)
From: Cyrill Gorcunov <gorcunov@gmail.com>
Date: Fri, 9 Oct 2020 00:36:05 +0300
Message-Id: <20201008213608.1022476-4-gorcunov@gmail.com>
In-Reply-To: <20201008213608.1022476-1-gorcunov@gmail.com>
References: <20201008213608.1022476-1-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [Tarantool-patches] [PATCH v5 3/6] box/func: more detailed error in
module reloading
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>,
<mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>,
<mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: tml <tarantool-patches@dev.tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Otherwise it is unclear what exactly been failing.
Part-of #4642
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
src/box/func.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/box/func.c b/src/box/func.c
index 452866a5d..89796310f 100644
--- a/src/box/func.c
+++ b/src/box/func.c
@@ -471,8 +471,11 @@ module_reload(const char *package, const char *package_end, struct module **modu
struct func_name name;
func_split_name(mod_sym->name, &name);
mod_sym->addr = module_sym(new_module, name.sym);
- if (mod_sym->addr == NULL)
+ if (mod_sym->addr == NULL) {
+ say_error("module: reload %s, symbol %s not found",
+ package, name.sym);
goto restore;
+ }
mod_sym->module = new_module;
rlist_move(&new_module->funcs, &mod_sym->item);
}
--
2.26.2