From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 38134469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  6 Oct 2020 15:46:49 +0300 (MSK)
Date: Tue, 6 Oct 2020 15:46:46 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20201006124646.GA331917@hpalx>
References: <cover.1601977644.git.kyukhin@tarantool.org>
 <60bc8f4890c83dc5bd5a8bdf6d4e5eeab1551a64.1601977644.git.kyukhin@tarantool.org>
 <20201006112123.g52kaxkqlpkgp4bz@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20201006112123.g52kaxkqlpkgp4bz@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/2] ci: add replace clang8 with
	clang11
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi Kirill, thanks for the patch, it LGTM.

On Tue, Oct 06, 2020 at 02:21:23PM +0300, Kirill Yukhin wrote:
> Hello,
> 
> On 06 окт 12:59, Kirill Yukhin wrote:
> > Update Clang 8 testing with most recent version of
> > Clang: 11.
> > 
> > Closes #5386
> 
> It was decided to keep clang8 as well. Iterative patch
> in the bottom. Docker pre-built image updated. Branch
> force-pushed.
> 
> --
> Regards, Kirill Yukhin
> 
> diff --git a/.gitlab.mk b/.gitlab.mk
> index 6e260dc..e1a83ac 100644
> --- a/.gitlab.mk
> +++ b/.gitlab.mk
> @@ -40,7 +40,7 @@ export DEBIAN_STRETCH_DOCKERFILE
>  define DEBIAN_BUSTER_DOCKERFILE
>  FROM packpack/packpack:debian-buster
>  COPY .travis.mk .
> -RUN make APT_EXTRA_FLAGS="--allow-releaseinfo-change-version --allow-releaseinfo-change-suite" -f .travis.mk deps_buster_clang_11
> +RUN make APT_EXTRA_FLAGS="--allow-releaseinfo-change-version --allow-releaseinfo-change-suite" -f .travis.mk deps_buster_clang_8 deps_buster_clang_11
>  endef
>  export DEBIAN_BUSTER_DOCKERFILE
> 
> diff --git a/.travis.mk b/.travis.mk
> index 88ddbe4..d797472 100644
> --- a/.travis.mk
> +++ b/.travis.mk
> @@ -76,6 +76,13 @@ deps_debian:
>                 python-msgpack python-yaml python-argparse python-six python-gevent \
>                 lcov ruby clang llvm llvm-dev zlib1g-dev autoconf automake libtool
> 
> +deps_buster_clang_8: deps_debian
> + echo "deb http://apt.llvm.org/buster/ llvm-toolchain-buster-8 main" > /etc/apt/sources.list.d/clang_8.list
> + echo "deb-src http://apt.llvm.org/buster/ llvm-toolchain-buster-8 main" >> /etc/apt/sources.list.d/clang_8.list
> + wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | apt-key add -
> + apt-get update
> + apt-get install -y clang-8 llvm-8-dev
> +
>  deps_buster_clang_11: deps_debian
>         echo "deb http://apt.llvm.org/buster/ llvm-toolchain-buster-11 main" > /etc/apt/sources.list.d/clang_11.list
>         echo "deb-src http://apt.llvm.org/buster/ llvm-toolchain-buster-11 main" >> /etc/apt/sources.list.d/clang_11.list