From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 53B95469719 for ; Mon, 5 Oct 2020 14:58:05 +0300 (MSK) Date: Mon, 5 Oct 2020 14:58:19 +0300 From: Alexander Turenko Message-ID: <20201005115819.n6sx2dvkteyvtnw6@tkn_work_nb> References: <078239e37414bb009729bddf1d0822c9c978966b.1600824556.git.alexander.turenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 1.10 02/16] refactoring: adjust contract of luaT_tuple_new() List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org On Mon, Sep 28, 2020 at 11:26:05PM +0200, Vladislav Shpilevoy wrote: > Hi! Thanks for the patch! > > There is no 'refactoring:' subsystem. Lets use 'lua:'. TL;RD: Changed (will be so in the next patchset version). Hm. I re-read the formal rule in our guidelines and it's origin (kernel's guidelines): you're right, a prefix should be a subsystem. I also looked over kernel's commits and, yep, actual commits are prefixed with a subsystem. I found it meaningful, when you have a lot of (at least several) subsystems and there are persons, who look only at some of them: when a project is relatively large. When a project is quite small and subsystems are like 'code', 'test', 'build system', 'ci', the 'refactoring' prefix is useful to mark changes, which do not change a user visible behaviour. Anyway, tarantool is surely large enough to prefer a subsystem here. I agree. Aside of this, I reworded a bit the explanation why the original commit message is strage: | The original message is a bit misleading, because the message was not | rewritten after introduction of the function with the same name in | 9e2a905c069e58cdd95d91868025391ecd9404e6 ('box: fix format of tuple | produced with frommap()'). Those patches were created in parallel. (Changed 'it' -> 'the message'. Added the last sentence.)