From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2E447469719 for ; Fri, 2 Oct 2020 15:55:09 +0300 (MSK) Date: Fri, 2 Oct 2020 15:44:33 +0300 From: Igor Munkin Message-ID: <20201002124433.GH18920@tarantool.org> References: <20201002124355.2pbrgjqusdy47dga@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201002124355.2pbrgjqusdy47dga@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2 0/2] Prevent JIT engine breakage on fibers switch-over List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirill Yukhin Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy Kirill, On 02.10.20, Kirill Yukhin wrote: > Hello, > > On 23 сен 22:06, Igor Munkin wrote: > > There was a long discussion about the patch correctness and its > > performance impact in v1 thread[1]. The benchmarks provided in v1 showed > > this implementation as the least nerfing the platform overall > > performance even for such synthetic test[2]. One can find the relevant > > benchmarks results in the corresponding patches. > > > > Changes in v2: > > * implement the callback in a different way to negate its perf impact > > > > @ChangeLog: > > * Fixed fibers switch-over to prevent JIT machinery misbehaviour. Trace > > recording is aborted when fiber yields the execution. The yield > > occuring while mcode is being run leads to the platform panic > > (gh-1700, gh-4491). > > > > Branch: https://github.com/tarantool/tarantool/tree/imun/gh-1700-abort-recording-on-fiber-switch > > Issues: > > * https://github.com/tarantool/tarantool/issues/1700 > > * https://github.com/tarantool/tarantool/issues/4491 > > > > [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-March/015290.html > > [2]: https://gist.github.com/igormunkin/7e0cf48005bd003ffbdf30181eedb40e > > I've checked your patch set into 1.10, 2.4, 2.5 and master. Thanks, I've updated the corresponding release notes. > > -- > Regards, Kirill Yukhin -- Best regards, IM