From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 095EA469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 29 Sep 2020 13:16:50 +0300 (MSK)
Date: Tue, 29 Sep 2020 13:06:15 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200929100615.GX18920@tarantool.org>
References: <cover.1600862684.git.imun@tarantool.org>
 <6b7def49c9d2252425d3944cc4274c9a155ae9e9.1600862684.git.imun@tarantool.org>
 <9D468A12-77EE-4876-BD91-BC9D840E0D08@tarantool.org>
 <20200928130725.GR18920@tarantool.org>
 <20200928153627.GS18920@tarantool.org>
 <20200928163757.GT18920@tarantool.org>
 <20200928174520.GU18920@tarantool.org>
 <20200929092412.GC35@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200929092412.GC35@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 2/2] lua: abort trace recording
	on fiber yield
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Sergos,

Thanks for your review!

On 29.09.20, Sergey Ostanevich wrote:
> Hi!
> 
> Thanks for the patch!
> 
> I wonder how many tests are failing due to #4819 and are they covered 
> with skip conditions?

I know only three: this one and two from LuaJIT tests (for FFI sandwich
and flushing trace while running one).

> Also, how will we fix all those tests after FreeBSD fixup?

Just remove this skipcond file. The problem is JIT fails to assemble the
recorded trace, so the mcode is not generated and the "desired" platform
panic doesn't occur. When the issue is fixed, the test should be fine.

> 
> The patchset is LGTM to me.

Added your tag:
| Reviewed-by: Sergey Ostanevich <sergos@tarantool.org>

> 
> Regards,
> Sergos
> 
> On 28 сен 20:45, Igor Munkin wrote:
> > Meh, the last one (I hope): I forgot there are the issues with JIT on
> > FreeBSD[1]. So I added skipcond file for the newly added test:
> > 

<snipped>

> > 
> > [1]: https://github.com/tarantool/tarantool/issues/4819
> > 
> > -- 
> > Best regards,
> > IM

-- 
Best regards,
IM