From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergos@tarantool.org>
Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id CAC5D469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 29 Sep 2020 12:14:29 +0300 (MSK)
Date: Tue, 29 Sep 2020 12:14:28 +0300
From: Sergey Ostanevich <sergos@tarantool.org>
Message-ID: <20200929091428.GA35@tarantool.org>
References: <cover.1600862684.git.imun@tarantool.org>
 <4AE5222F-22B2-4752-AD8C-E5C1CCF7FE13@tarantool.org>
 <20200928130650.GP18920@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200928130650.GP18920@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] Prevent JIT engine breakage
	on fibers switch-over
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Hi!

Thanks for the update, LGTM.

Sergos

On 28 сен 16:06, Igor Munkin wrote:
> Sergos,
> 
> Thanks for your review!
> 
> On 24.09.20, sergos@tarantool.org wrote:
> > Hi!
> > 
> > Thanks for the patch, please consider my 2 cents below.
> > 
> > Sergos
> > 
> > > On 23 Sep 2020, at 22:06, Igor Munkin <imun@tarantool.org> wrote:
> > > 
> 
> <snipped>
> 
> > > 
> > > @ChangeLog:
> > > * Fixed fibers switch-over to prevent JIT machinery misbehaviour. Trace
> > >  recording is aborted when fiber yields the execution. The yield
> > >  occuring while mcode is being run leads to the platform panic
> > 
> > Could you please rephrase the last sentence to be more clear, like
> > yielding from a function called directly from the jitted code (means -
> > through FFI) will cause panic.
> 
> I guess the following wording is quite close to the one you desire:
> 
> @ChangeLog:
> * Fixed fibers switch-over to prevent JIT machinery misbehaviour. Trace
>   recording is aborted when fiber yields the execution. The yield
>   occuring while the compiled code is being run (it's likely a function
>   with a yield underneath called via LuaJIT FFI) leads to the platform
>   panic (gh-1700, gh-4491).
> 
> > 
> > >  (gh-1700, gh-4491).
> > > 
> 
> <snipped>
> 
> > > 
> > > -- 
> > > 2.25.0
> > > 
> > 
> 
> -- 
> Best regards,
> IM