From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1D085469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 29 Sep 2020 11:13:38 +0300 (MSK)
Date: Tue, 29 Sep 2020 11:03:04 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200929080304.GV18920@tarantool.org>
References: <cover.1600955781.git.tsafin@tarantool.org>
 <96922008cb146eaa04cb727472eda3e71f2e7bc8.1600955781.git.tsafin@tarantool.org>
 <185c95b5-edc6-10d0-50c0-ba7c086fc97a@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <185c95b5-edc6-10d0-50c0-ba7c086fc97a@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2.X 4/7] module api:
 luaL_register_module & luaL_register_type
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko <alexander.turenko@tarantool.org>

Vlad,

I glanced the patch and doubt these functions need to be exported by
Tarantool. These functions neither wrap internals nor provide any
performance benefits (e.g. reduce numbers of excess allocations). It
would be nice to have such auxiliary interfaces in so called "modulekit"
to make third party modules development easier, but I see no problem to
borrow this code to merger/key_def as is for now.

On 29.09.20, Vladislav Shpilevoy wrote:
> Thanks for the patch!
> 
> See 2 comments below.
> 
> On 24.09.2020 19:00, Timur Safin wrote:
> > Exporting `luaL_register_module` & `luaL_register_type`
> > functions as they needed for external merger
> > 
> > diff --git a/src/lua/utils.h b/src/lua/utils.h
> > index 7639cd64a..9b1fe7e57 100644
> > --- a/src/lua/utils.h
> > +++ b/src/lua/utils.h
> > @@ -78,6 +78,8 @@ luaL_pushuuid(struct lua_State *L);
> >  
> >  /** \cond public */
> >  
> > +struct luaL_Reg;
> 
> 1. It does not seem to be public. How are users supposed to work with that?
> Igor, could you please take a look at this?

It's public[1] and is provided by <lauxlib.h> Lua standard header as
Sasha already mentioned it in the thread.

> 

<snipped>

[1]: https://www.lua.org/manual/5.1/manual.html#luaL_Reg

-- 
Best regards,
IM