From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1EC80469719 for ; Tue, 29 Sep 2020 08:25:38 +0300 (MSK) Date: Tue, 29 Sep 2020 08:25:49 +0300 From: Alexander Turenko Message-ID: <20200929052549.wqveolqpgroqfqjg@tkn_work_nb> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 2.X 1/7] module api: export box_tuple_validate List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Timur Safin Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org > Part of #5273 Sorry for nitpicking, but the issue states 'expose everything that is needed for external key_def module'. The commit technically is not part of the issue. Either change the issue, or link commits with tarantool/vshard-cluster-api#5, or file a separate issue (I would do the latter). It is just to don't mix different things into one: #5273 have certain definition of done. It will be hard to understand what going on in the future if we'll mix everything together. (It is the same for all commits.)