Tarantool development patches archive
 help / color / mirror / Atom feed
From: Nikita Pettik <korablev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] box: disallow to modify format of a view
Date: Mon, 28 Sep 2020 23:50:48 +0000	[thread overview]
Message-ID: <20200928235048.GE14909@tarantool.org> (raw)
In-Reply-To: <020b2176-3695-5371-f936-742fe59d97ff@tarantool.org>

On 28 Sep 20:41, Vladislav Shpilevoy wrote:
> It seems this is a bugfix and should be pushed to the older version too.

I consider this change to be very minor and don't think it is worth
backporting. If you really feel that it must be backported - feel free to do it.
 
> On 28.09.2020 17:52, Nikita Pettik wrote:
> > On 26 Sep 16:01, Roman Khabibov wrote:
> >> Hi! Thanks.
> >>
> >> Nikita, could you, please, look through?
> > 
> > Changed error msg to 'view can not be altered' and pushed to master.
> > Changelog for 2.6 is updated; branch is dropped.
> >  
> >>> On Sep 25, 2020, at 23:14, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> wrote:
> >>>
> >>> Hi! Thanks for the patch!
> >>>
> >>> LGTM.
> >>

  reply	other threads:[~2020-09-28 23:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22 15:59 Roman Khabibov
2020-09-24 20:59 ` Vladislav Shpilevoy
2020-09-25 10:18   ` Roman Khabibov
2020-09-25 20:14 ` Vladislav Shpilevoy
2020-09-26 13:01   ` Roman Khabibov
2020-09-28 15:52     ` Nikita Pettik
2020-09-28 18:41       ` Vladislav Shpilevoy
2020-09-28 23:50         ` Nikita Pettik [this message]
2020-10-01 22:35           ` Vladislav Shpilevoy
2020-10-02 11:13             ` Nikita Pettik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200928235048.GE14909@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] box: disallow to modify format of a view' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox