From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A2E0F446439 for ; Mon, 28 Sep 2020 18:56:00 +0300 (MSK) Date: Mon, 28 Sep 2020 15:55:59 +0000 From: Nikita Pettik Message-ID: <20200928155559.GB14909@tarantool.org> References: <73779905e2350c2ecf37cfe744058e3fa61b4ded.1601129563.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <73779905e2350c2ecf37cfe744058e3fa61b4ded.1601129563.git.imeevma@gmail.com> Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: remove OP_Realify List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org On 26 Sep 17:15, imeevma@tarantool.org wrote: > This opcode was used to convert INTEGER values to REAL. It is not > necessary in Tarantool and may cause errors. Add justification: what this change fixes, in which way etc. > Closes #5335 > --- > https://github.com/tarantool/tarantool/issues/5335 > https://github.com/tarantool/tarantool/tree/imeevma/gh-5335-remove-op-realify > > @ChangeLog > - Fixed a bug with unnecessary convertion from INTEGER to DOUBLE (gh-5335). > > src/box/sql/delete.c | 12 ----- > src/box/sql/expr.c | 13 ----- > src/box/sql/vdbe.c | 17 ------- > ...-unnecessary-conversation-to-double.result | 51 +++++++++++++++++++ > ...nnecessary-conversation-to-double.test.lua | 11 ++++ > 5 files changed, 62 insertions(+), 42 deletions(-) > create mode 100644 test/sql/gh-5335-unnecessary-conversation-to-double.result > create mode 100644 test/sql/gh-5335-unnecessary-conversation-to-double.test.lua > > diff --git a/src/box/sql/delete.c b/src/box/sql/delete.c > index 68abd1f58..a78c68df6 100644 > --- a/src/box/sql/delete.c > +++ b/src/box/sql/delete.c > @@ -565,18 +565,6 @@ sql_generate_index_key(struct Parse *parse, struct index *index, int cursor, > } > uint32_t tabl_col = index->def->key_def->parts[j].fieldno; > sqlVdbeAddOp3(v, OP_Column, cursor, tabl_col, reg_base + j); > - /* > - * If the column type is NUMBER but the number > - * is an integer, then it might be stored in the > - * table as an integer (using a compact > - * representation) then converted to REAL by an > - * OP_Realify opcode. But we are getting > - * ready to store this value back into an index, > - * where it should be converted by to INTEGER > - * again. So omit the OP_Realify opcode if > - * it is present > - */ > - sqlVdbeDeletePriorOpcode(v, OP_Realify); > } > if (reg_out != 0) > sqlVdbeAddOp3(v, OP_MakeRecord, reg_base, col_cnt, reg_out);