From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imeevma@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5BCB9469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 28 Sep 2020 18:50:39 +0300 (MSK)
Date: Mon, 28 Sep 2020 18:50:37 +0300
From: Mergen Imeev <imeevma@tarantool.org>
Message-ID: <20200928155037.GA77246@tarantool.org>
References: <cover.1598000242.git.imeevma@gmail.com>
 <ad5ea132af70b485aad33469bcd531c0131ffeb2.1598000242.git.imeevma@gmail.com>
 <20200917144808.GG10599@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200917144808.GG10599@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v5 1/6] sql: remove unused DOUBLE to
	INTEGER conversion
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thank you for the review. My answer below.

On Thu, Sep 17, 2020 at 02:48:08PM +0000, Nikita Pettik wrote:
> On 21 Aug 12:19, imeevma@tarantool.org wrote:
> > This patch removes the unused DOUBLE to INTEGER conversion from OP_Seek*
> > opcodes. This transformation is not used due to changes in the ApplyType
> 
> What changes are..?

Changed commit-message a bit:

This patch removes the unused DOUBLE to INTEGER conversion from OP_Seek*
opcodes. This conversion is not used due to changes in the ApplyType
opcode after #3809. The next few patches will introduce new rules for
converting numbers (not just DOUBLE to INTEGER), and the implicit
conversion within the ApplyType opcode will be disabled for this case.


> 
> > opcode. The next few patches will introduce new rules for converting
> > numbers (not just DOUBLE to INTEGER), and the implicit conversion within
> > the ApplyType opcode will be disabled for this case.
> > 
> > Part of #4230
> 
> LGTM