From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 477C244643A
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 28 Sep 2020 16:17:33 +0300 (MSK)
Date: Mon, 28 Sep 2020 16:06:58 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200928130658.GQ18920@tarantool.org>
References: <cover.1600862684.git.imun@tarantool.org>
 <12d3cc3577e45946a82c8d23b69508a4c5653346.1600862684.git.imun@tarantool.org>
 <C3672C09-1A4C-45AA-BF3C-888F5CFE0443@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <C3672C09-1A4C-45AA-BF3C-888F5CFE0443@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 1/2] fiber: introduce a callback
	for fibers switch-over
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "sergos@tarantool.org" <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Sergos,

Thanks for your review!

On 24.09.20, sergos@tarantool.org wrote:
> Hi!
> 
> Thank you for the patch, see my single comment below.
> 
> Regards,
> Sergos
> 
> > On 23 Sep 2020, at 22:06, Igor Munkin <imun@tarantool.org> wrote:
> > 

<snipped>

> > 
> > diff --git a/src/lib/core/fiber.c b/src/lib/core/fiber.c
> > index 483ae3ce1..1b7d255ff 100644
> > --- a/src/lib/core/fiber.c
> > +++ b/src/lib/core/fiber.c
> > @@ -46,6 +46,8 @@
> > #if ENABLE_FIBER_TOP
> > #include <x86intrin.h> /* __rdtscp() */
> > 
> 
> > +extern void cord_on_yield(void);
> > +
> 
> The definition is under ENABLE_FIBER_TOP, while its use isn’t. 
> The build will fail for ARM target for exmaple.
> AFAICS the changes are not releveant to the fiber top in any way.

Crap... Thanks for noticing! Fixed:

================================================================================

diff --git a/src/lib/core/fiber.c b/src/lib/core/fiber.c
index 1b7d255..223c841 100644
--- a/src/lib/core/fiber.c
+++ b/src/lib/core/fiber.c
@@ -43,11 +43,11 @@
 #include "trigger.h"
 #include "errinj.h"
 
+extern void cord_on_yield(void);
+
 #if ENABLE_FIBER_TOP
 #include <x86intrin.h> /* __rdtscp() */
 
-extern void cord_on_yield(void);
-
 static inline void
 clock_stat_add_delta(struct clock_stat *stat, uint64_t clock_delta)
 {

================================================================================

Side note: I guess we have to reprioritize ARM testing issue[1].

> 
> > static inline void
> > clock_stat_add_delta(struct clock_stat *stat, uint64_t clock_delta)
> > {

<snipped>

> > 
> 

[1]: https://github.com/tarantool/tarantool/issues/4270

-- 
Best regards,
IM