From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id EA62E469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 28 Sep 2020 09:59:21 +0300 (MSK)
Date: Mon, 28 Sep 2020 09:59:21 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200928065920.gzqf2ozymizqqflj@tarantool.org>
References: <20200920175930.9016-1-skaplun@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200920175930.9016-1-skaplun@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] cppcheck: box/alter.cc null pointer
 dereference
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Hello,

On 20 сен 20:59, Sergey Kaplun wrote:
> Found and fixed Null pointer dereference with cppcheck:
> 
> [src/box/alter.cc:395]: (error) Null pointer dereference
> ---
> 
> cppcheck can be run from root project directory as follows:
> ```
> $ cppcheck --force --enable=warning,performance,portability,information --error-exitcode=1 --verbose .
> ```

I've checked your patch into 2.4, 2.5 and master.

--
Regards, Kirill Yukhin