From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5E835469719 for ; Mon, 28 Sep 2020 09:54:59 +0300 (MSK) Date: Mon, 28 Sep 2020 09:54:58 +0300 From: Kirill Yukhin Message-ID: <20200928065458.gyg4hnkl6yaoqipv@tarantool.org> References: <20200921174837.30681-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200921174837.30681-1-skaplun@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] cppcheck: src/lua/fiber.c null pointer dereference List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko Hello, On 21 сен 20:48, Sergey Kaplun wrote: > Found and fixed possible null pointer dereference with cppcheck: > > [src/lua/fiber.c:245] -> [src/lua/fiber.c:217]: (warning) Either the condition 'if(func)' is redundant or there is possible null pointer dereference: func. > --- > > Branch: https://github.com/tarantool/tarantool/tree/skaplun/cppcheck-lua-fiber-possible-null-pointer-dereference I've checked your patch into 1.10, 2.4, 2.5 and master. -- Regards, Kirill Yukhin