From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 77626469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 25 Sep 2020 18:58:08 +0300 (MSK)
Date: Fri, 25 Sep 2020 18:58:07 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200925155807.vi3wy5ukqtw6evbf@tarantool.org>
References: <795f8ba8ccda19103e0357d0edc920fc4765a97b.1600801955.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <795f8ba8ccda19103e0357d0edc920fc4765a97b.1600801955.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] Enable test reruns on failed
	fragiled tests
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 22 сен 22:18, Alexander V. Tikhonov wrote:
> In test-run implemented the new format of the fragile lists based on
> JSON format set as fragile option in 'suite.ini' files per each suite:
> 
>    fragile = {
>         "retries": 10,
>         "tests": {
>             "bitset.test.lua": {
>                 "issues": [ "gh-4095" ],
>                 "checksums": [ "050af3a99561a724013995668a4bc71c", "f34be60193cfe9221d3fe50df657e9d3" ]
>             }
>         }}
> 
> Added ability to check results file checksum on tests fail and
> compare with the checksums of the known issues mentioned in the
> fragile list.
> 
> Also added ability to set 'retries' option, which sets the number
> of accepted reruns of the tests failed from 'fragile' list that
> have checksums on its fails.
> 
> Closes #5050

LGTM.
I've checked your patch into 1.10, 2.4, 2.5 master.

--
Regards, Kirill Yukhin