From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6E95A469719 for ; Thu, 24 Sep 2020 16:12:08 +0300 (MSK) Date: Thu, 24 Sep 2020 13:12:06 +0000 From: Nikita Pettik Message-ID: <20200924131205.GA27508@tarantool.org> References: <20200923142647.77892-1-roman.habibov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200923142647.77892-1-roman.habibov@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] sql: fix memleak during parsing List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Roman Khabibov Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org On 23 Sep 17:26, Roman Khabibov wrote: > Fix a memory leak generated by allocation of indexes array of > parser ephemeral space. > --- I'd fix a bit commit message: Fix a memory leak during execution of CREATE TABLE statement: indexes to be created are stored in space->index array, which in turn is allocated using malloc, but is never freed. LGTM otherwise. > Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/sql-memleak > > P.S. It's really memleak, I checked with valgrind. > > src/box/sql/tokenize.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/box/sql/tokenize.c b/src/box/sql/tokenize.c > index 5404a78e9..6cf92b4f7 100644 > --- a/src/box/sql/tokenize.c > +++ b/src/box/sql/tokenize.c > @@ -447,6 +447,8 @@ parser_space_delete(struct sql *db, struct space *space) > assert(space->def->opts.is_ephemeral); > for (uint32_t i = 0; i < space->index_count; ++i) > index_def_delete(space->index[i]->def); > + if (space->index_count != 0) > + free(space->index); > } > > /** > -- > 2.24.3 (Apple Git-128) >