From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 36608469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 24 Sep 2020 06:40:23 +0300 (MSK)
Date: Thu, 24 Sep 2020 06:40:31 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200924034031.htguqxtq3svnx2om@tkn_work_nb>
References: <faa2b6814dc8683935c6b42c8857ea6ba642781f.1600843050.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <faa2b6814dc8683935c6b42c8857ea6ba642781f.1600843050.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3] gitlab-ci: save failed test
	results artifacts
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Nothing contradicts with my vision (I became a bit more far from details
now). LGTM. Several comments below (no need to re-review with me if
you'll want to make changes according to those comments).

WBR, Alexander Turenko.

>  .vbox_template: &vbox_definition
>    stage: test
>    after_script:
> -    - ${GITLAB_MAKE} vms_shutdown
> +    - >
> +      scp -r -P ${VMS_PORT} ${VMS_USER}@127.0.0.1:tarantool/test/var/artifacts . ;
> +      ${GITLAB_MAKE} vms_shutdown
> +  <<: *artifacts_files_definition

Nit: Using literal style indicator (the pipe symbol instead of the angle
bracket) would look more intuitive and does not require the semicolon.
(The folded style ('>') replaces newlines with spaces and it should be
used when this behaviour is wanted I think.)

>  static_build_cmake_osx_15:
> -  stage: test
> +  <<: *osx_definition
>    tags:
>      - osx_15
>    script:

Nit: This change is not mentioned in the commit message.

> diff --git a/.travis.mk b/.travis.mk
> index d8f97ef5c..577970d8f 100644
> --- a/.travis.mk
> +++ b/.travis.mk
> @@ -242,11 +242,11 @@ INIT_TEST_ENV_OSX=\
>  		launchctl limit maxproc || : ; \
>  		ulimit -u ${MAX_PROC} || : ; \
>  		ulimit -u ; \
> -		rm -rf /tmp/tnt
> +		rm -rf ${OSX_VARDIR}

Just in case: should not we set some default value for this variable in
case we'll run this rule outside of CI (or in CI, which is not GitLab
CI)?