From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EC1EB469719 for ; Wed, 23 Sep 2020 17:26:50 +0300 (MSK) From: Roman Khabibov Date: Wed, 23 Sep 2020 17:26:47 +0300 Message-Id: <20200923142647.77892-1-roman.habibov@tarantool.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH] sql: fix memleak during parsing List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@dev.tarantool.org Cc: v.shpilevoy@tarantool.org Fix a memory leak generated by allocation of indexes array of parser ephemeral space. --- Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/sql-memleak P.S. It's really memleak, I checked with valgrind. src/box/sql/tokenize.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/box/sql/tokenize.c b/src/box/sql/tokenize.c index 5404a78e9..6cf92b4f7 100644 --- a/src/box/sql/tokenize.c +++ b/src/box/sql/tokenize.c @@ -447,6 +447,8 @@ parser_space_delete(struct sql *db, struct space *space) assert(space->def->opts.is_ephemeral); for (uint32_t i = 0; i < space->index_count; ++i) index_def_delete(space->index[i]->def); + if (space->index_count != 0) + free(space->index); } /** -- 2.24.3 (Apple Git-128)