From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B5FAE446439
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 23 Sep 2020 13:26:06 +0300 (MSK)
Date: Wed, 23 Sep 2020 10:26:06 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200923102605.GB21612@tarantool.org>
References: <1599560532-27089-1-git-send-email-alyapunov@tarantool.org>
 <1599560532-27089-11-git-send-email-alyapunov@tarantool.org>
 <20200915175921.GC23208@tarantool.org>
 <e66b7ebc-63ef-4c78-99d1-2db070fd0b0b@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <e66b7ebc-63ef-4c78-99d1-2db070fd0b0b@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 10/12] txm: use new tx manager in
 memtx
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Aleksandr Lyapunov <alyapunov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 22 Sep 20:53, Aleksandr Lyapunov wrote:
> Hi, thanks for the review.
> Almost all if fixed, see my comment below:
> 
> On 15.09.2020 20:59, Nikita Pettik wrote:
> > 
> > > diff --git a/src/box/vinyl.c b/src/box/vinyl.c
> > > index aa6e50f..cee39c5 100644
> > > --- a/src/box/vinyl.c
> > > +++ b/src/box/vinyl.c
> > > @@ -1076,7 +1076,7 @@ vinyl_space_check_format(struct space *space, struct tuple_format *format)
> > >   		return -1;
> > >   	/* See the comment in vinyl_space_build_index(). */
> > > -	txn_can_yield(txn, true);
> > > +	bool could_yield = txn_can_yield(txn, true);
> > Don't get why vinyl related functions should be involved in this change..
> > The rest is OK.
> These vinyl functions are called in memtx transaction that performs alter of
> a vinyl space..
> In the code vinyl changes behavior of the memtx transaction.

Ok, get it, thx.