From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id E765E469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 23 Sep 2020 13:25:36 +0300 (MSK)
Date: Wed, 23 Sep 2020 10:25:36 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200923102536.GA21612@tarantool.org>
References: <1599560532-27089-1-git-send-email-alyapunov@tarantool.org>
 <1599560532-27089-8-git-send-email-alyapunov@tarantool.org>
 <20200915143357.GB23208@tarantool.org>
 <6c7eb860-781c-78b4-3fca-49199de2aa64@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <6c7eb860-781c-78b4-3fca-49199de2aa64@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 07/12] txm: introduce memtx_story
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Aleksandr Lyapunov <alyapunov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 22 Sep 20:51, Aleksandr Lyapunov wrote:
> Thank for the review.
> Most is fixed, see my replies below.
> 
> On 15.09.2020 17:33, Nikita Pettik wrote:
> 
> > > +int
> > > +memtx_tx_track_read(struct txn *txn, struct space *space, struct tuple *tuple)
> > > +{
> > > +	if (tuple == NULL)
> > > +		return 0;
> > > +	if (txn == NULL)
> > > +		return 0;
> > > +	if (space == NULL)
> > > +		return 0;
> > Space seems to be always != NULL. If so, let's replace it with an assertion.
> I found out that in iterators the space can be NULL. I'm not sure
> why, but I happens without my patch set. I just accepted it.
>

Hm, sounds strange. I've replaced this check with an assertion and all tests
seem to pass..