From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 25188469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 23 Sep 2020 08:18:04 +0300 (MSK)
Date: Wed, 23 Sep 2020 08:18:03 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20200923051802.GA10528@hpalx>
References: <ecb3c3dba9338ecee6387cc4b74671a938d48389.1600786660.git.kyukhin@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ecb3c3dba9338ecee6387cc4b74671a938d48389.1600786660.git.kyukhin@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] coio: fix cord leak on stop
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi Kirill, thanks for the patch. I've checked it and seems that the
fixed lsan susspension can be removed, please use the following patch
before commit to releases:

diff --git a/asan/lsan.supp b/asan/lsan.supp
index 46b3001e9..f1ec60da3 100644
--- a/asan/lsan.supp
+++ b/asan/lsan.supp
@@ -43,8 +43,6 @@ leak:tt_bitset_iterator_init
 leak:libc.so*
 
 # test: box-tap/schema_mt.test.lua
-# source: src/lib/core/coio_task.c
-leak:coio_on_start
 # source: src/lib/salad/mhash.h
 leak:mh_i32ptr_new
 
Also the patch LGTM.

On Tue, Sep 22, 2020 at 05:59:47PM +0300, Kirill Yukhin wrote:
> cord_ptr variable is calloc()-ated in coio_on_start()
> and is not free()-ed, which triggers ASAN. free() it
> in coio_on_stop().
> 
> Closes #5308
> ---
> 
> Branch: https://github.com/tarantool/tarantool/tree/kyukhin/gh-5308-cord-leak
> Issue: https://github.com/tarantool/tarantool/issues/5308
> ChangeLog: not user visible
> 
>  src/lib/core/coio_task.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/lib/core/coio_task.c b/src/lib/core/coio_task.c
> index 83f669d..c8be2de 100644
> --- a/src/lib/core/coio_task.c
> +++ b/src/lib/core/coio_task.c
> @@ -123,6 +123,7 @@ coio_on_stop(void *data)
>  {
>  	(void) data;
>  	cord_destroy(cord());
> +	free(cord());
>  	return 0;
>  }
>  
> -- 
> 1.8.3.1
>