From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5C330469719 for ; Mon, 21 Sep 2020 23:37:27 +0300 (MSK) Date: Mon, 21 Sep 2020 23:37:06 +0300 From: Sergey Kaplun Message-ID: <20200921203706.GA20060@root> References: <20200920175930.9016-1-skaplun@tarantool.org> <539965bb-7c2b-6962-530f-d9494a71b260@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <539965bb-7c2b-6962-530f-d9494a71b260@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] cppcheck: box/alter.cc null pointer dereference List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Hi! Thanks for the review! On 21.09.20, Vladislav Shpilevoy wrote: > Hi! Thanks for the patch! > > Commit title should be a subsystem name + description. Since we > don't have 'cppcheck' subsystem, I propose to use 'alter'. > > LGTM except the commit title. I've updated commit message to: ``` alter: box/alter.cc null pointer dereference Found and fixed Null pointer dereference with cppcheck: [src/box/alter.cc:395]: (error) Null pointer dereference ``` and pushed it to the branch. -- Best regards, Sergey Kaplun