From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 4E080469719
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 19 Sep 2020 10:08:53 +0300 (MSK)
Date: Sat, 19 Sep 2020 10:08:49 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20200919070849.GA578@hpalx>
References: <f7bcdf4c0405112d390b8ebb6d296717153020ef.1600467674.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f7bcdf4c0405112d390b8ebb6d296717153020ef.1600467674.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/1] tests: fix
	replication/prune.test.lua hang
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi Vlad, thanks for the fast fix. I've checked it and the issue
seems completele fixed, also commit testing passed:
https://gitlab.com/tarantool/tarantool/-/jobs/746376811#L4654
The patch LGTM.

On Sat, Sep 19, 2020 at 12:21:47AM +0200, Vladislav Shpilevoy wrote:
> The test tried to start a replica whose box.cfg would hang, with
> replication_connect_quorum = 0 to make it return immediately.
> 
> But the quorum parameter was added and removed during work on
> 444213178c6260d6adfd640f7e4a0c5e6f8f2458 ("replication: do not
> register outgoing connections"). Instead, to start the replica
> without blocking on box.cfg it is necessary to pass 'wait=False'
> with the test_run:cmd('start server') command.
> 
> Closes #5311
> ---
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5311-prune-hangs
> Issue: https://github.com/tarantool/tarantool/issues/5311
> 
>  test/replication/prune.result   | 2 +-
>  test/replication/prune.test.lua | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/test/replication/prune.result b/test/replication/prune.result
> index 67fd62990..e25e9684e 100644
> --- a/test/replication/prune.result
> +++ b/test/replication/prune.result
> @@ -137,7 +137,7 @@ test_run:cmd('stop server replica1')
>  ---
>  - true
>  ...
> -test_run:cmd('start server replica1 with args="true 0"')
> +test_run:cmd('start server replica1 with args="true", wait=False')
>  ---
>  - true
>  ...
> diff --git a/test/replication/prune.test.lua b/test/replication/prune.test.lua
> index ea8b0b3c3..68300b270 100644
> --- a/test/replication/prune.test.lua
> +++ b/test/replication/prune.test.lua
> @@ -66,7 +66,7 @@ test_run:cmd('eval replica1 "box.info.replication[1].upstream.message"')
>  
>  -- restart replica and check that replica isn't able to join to cluster
>  test_run:cmd('stop server replica1')
> -test_run:cmd('start server replica1 with args="true 0"')
> +test_run:cmd('start server replica1 with args="true", wait=False')
>  test_run:cmd('switch replica1')
>  test_run:wait_upstream(1, {message_re = "Can't subscribe non%-anonymous replica"})
>  test_run:cmd('switch default')
> -- 
> 2.21.1 (Apple Git-122.3)
>