From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id DEE7A469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 18 Sep 2020 17:23:11 +0300 (MSK)
Date: Fri, 18 Sep 2020 17:23:06 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20200918142306.GB27064@hpalx>
References: <cover.1600239621.git.sergeyb@tarantool.org>
 <bf432ee3345e867985d35cacd31d5e48d72769d8.1600239621.git.sergeyb@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bf432ee3345e867985d35cacd31d5e48d72769d8.1600239621.git.sergeyb@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/4] cmake: add targets to run
	Jepsen tests
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

Hi Sergey, thanks for the patch. It has 2 make targets which will be
usable for tests reproduce. Later I hope we'll make some more
instructions on its use, but not now, so patch LGTM.

On Wed, Sep 16, 2020 at 10:07:21AM +0300, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Added targets 'make jepsen-single' and 'make jepsen-cluster'
> to run Jepsen tests on a single Tarantool instance and
> cluster of Tarantool instances.
> 
> Part of #5277
> ---
>  CMakeLists.txt | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 695e80c21..e8850e320 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -17,9 +17,11 @@ include(TestBigEndian)
>  include(CheckFunctionExists)
>  include(FindOptionalPackage)
>  include(FindPackageMessage)
> +include(ExternalProject)
>  
>  find_program(ECHO echo)
>  find_program(CAT cat)
> +find_program(BASH bash)
>  find_program(GIT git)
>  find_program(LD ld)
>  find_program(CTAGS ctags)
> @@ -162,6 +164,31 @@ add_custom_command(TARGET luacheck
>      COMMENT "Perform static analysis of Lua code"
>  )
>  
> +ExternalProject_Add(
> +    jepsen-tests
> +    GIT_REPOSITORY https://github.com/tarantool/jepsen.tarantool
> +    CONFIGURE_COMMAND ""
> +    BUILD_COMMAND ""
> +    INSTALL_COMMAND ""
> +    TEST_COMMAND ""
> +)
> +
> +#
> +# Enable 'make jepsen-*' targets.
> +#
> +
> +add_custom_target(jepsen-single DEPENDS jepsen-tests)
> +add_custom_command(TARGET jepsen-single
> +    COMMAND ${BASH} ${PROJECT_SOURCE_DIR}/tools/run-jepsen-tests.sh ${PROJECT_SOURCE_DIR} ${PROJECT_BINARY_DIR}
> +    COMMENT "Running Jepsen tests on a single Tarantool instance"
> +)
> +
> +add_custom_target(jepsen-cluster DEPENDS jepsen-tests)
> +add_custom_command(TARGET jepsen-cluster
> +    COMMAND ${BASH} ${PROJECT_SOURCE_DIR}/tools/run-jepsen-tests.sh ${PROJECT_SOURCE_DIR} ${PROJECT_BINARY_DIR} 5
> +    COMMENT "Running Jepsen tests on a cluster with 5 Tarantool instances"
> +)
> +
>  #
>  # Get version
>  #
> -- 
> 2.25.1
>