From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 48D11469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 18 Sep 2020 15:32:00 +0300 (MSK)
Date: Fri, 18 Sep 2020 12:31:59 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200918123159.GK10599@tarantool.org>
References: <20200911215115.6622-1-roman.habibov@tarantool.org>
 <20200911215115.6622-3-roman.habibov@tarantool.org>
 <20200916132708.GB10599@tarantool.org>
 <0d1cda9d-43d6-5f5b-01c7-e01c3579ac3f@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <0d1cda9d-43d6-5f5b-01c7-e01c3579ac3f@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 2/6] sql: refactor
 create_table_def and parse
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 17 Sep 16:43, Vladislav Shpilevoy wrote:
> On 16.09.2020 15:27, Nikita Pettik wrote:
> > On 12 Sep 00:51, Roman Khabibov wrote:
> >> Move ck, fk constraint lists and autoincrement info from
> >> struct create_table_def to struct Parse to make the code more
> >> reusable when implementing <ALTER TABLE ADD COLUMN>.
> >>
> >> Needed for #3075
> >> ---
> > 
> > Does ANSI allow to include constraints in ADD COLUMN statement?
> 
> Yes.
> 
> > Why did you decide to add autoincrement to this list? Was there any
> > discussion on this subj?
> 
> There is nothing to discuss. It is either a part of the standard or
> not. Romain said it is (I didn't check though).

Unfortunatelly, this is false statement - autoincrement is not a part of
standard (I've checked 2011 edition).