From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2FC20469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 18 Sep 2020 15:26:30 +0300 (MSK)
Date: Fri, 18 Sep 2020 15:26:29 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200918122629.ucdpf7xabskxm6k6@tarantool.org>
References: <20200917135121.60380-1-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200917135121.60380-1-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH 0/3] lua/pwd: workaround the systemd
 bug
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>, Alexander Turenko <alexander.turenko@tarantool.org>

Hello,

On 17 сен 16:51, Cyrill Gorcunov wrote:
> Guys, take a look please once time permit. The first two patches
> are optional but I think while we're at this code and we could
> improve the code base we should.
> 
> Also I've been thinking on how to test the issue -- we need a buggy
> systemd instance running and we actually have Fedora 29 on gitlab
> where tests are passed but it is unclear for me how exactly we could
> use it. Initially I thought of injecting some error code into pwd module
> itself but then I left this idea of making code more ugly just because
> of some bug in the particular systemd version.
> 
> So my criteria was that the change must not break anything in existing
> tests but if you have some idea for testing, please share.
> 
> issue https://github.com/tarantool/tarantool/issues/5034
> branch gorcunov/gh-5034-passwd

LGTM.
I've checked your patch into 1.10, 2.4, 2.5 and master.

Could you please update release notes since I see no entry in cover letter.

--
Regards, Kirill Yukhin