From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp1.mail.ru (smtp1.mail.ru [94.100.179.111])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 40FA3469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 17 Sep 2020 17:48:09 +0300 (MSK)
Date: Thu, 17 Sep 2020 14:48:08 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200917144808.GG10599@tarantool.org>
References: <cover.1598000242.git.imeevma@gmail.com>
 <ad5ea132af70b485aad33469bcd531c0131ffeb2.1598000242.git.imeevma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ad5ea132af70b485aad33469bcd531c0131ffeb2.1598000242.git.imeevma@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v5 1/6] sql: remove unused DOUBLE to
	INTEGER conversion
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

On 21 Aug 12:19, imeevma@tarantool.org wrote:
> This patch removes the unused DOUBLE to INTEGER conversion from OP_Seek*
> opcodes. This transformation is not used due to changes in the ApplyType

What changes are..?

> opcode. The next few patches will introduce new rules for converting
> numbers (not just DOUBLE to INTEGER), and the implicit conversion within
> the ApplyType opcode will be disabled for this case.
> 
> Part of #4230

LGTM