From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 188CB469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 16 Sep 2020 16:37:29 +0300 (MSK)
Date: Wed, 16 Sep 2020 13:37:28 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200916133728.GD10599@tarantool.org>
References: <20200911215115.6622-1-roman.habibov@tarantool.org>
 <20200911215115.6622-6-roman.habibov@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200911215115.6622-6-roman.habibov@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 5/6] box: disallow to modify
 format of a view
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

On 12 Sep 00:51, Roman Khabibov wrote:
> Disallow to modify format and field_count of a view.

Please add rationale
 
> Needed for #3075
> ---
>  src/box/alter.cc                          |  8 ++++
>  test/box/view-dont-modify-format.result   | 51 +++++++++++++++++++++++
>  test/box/view-dont-modify-format.test.lua | 18 ++++++++
>  3 files changed, 77 insertions(+)
>  create mode 100644 test/box/view-dont-modify-format.result
>  create mode 100644 test/box/view-dont-modify-format.test.lua
> 
> diff --git a/src/box/alter.cc b/src/box/alter.cc
> index ba96d9c62..3bfbb690a 100644
> --- a/src/box/alter.cc
> +++ b/src/box/alter.cc
> @@ -2441,6 +2441,14 @@ on_replace_dd_space(struct trigger * /* trigger */, void *event)
>  				  "view");
>  			return -1;
>  		}
> +		if (def->opts.is_view && (def->field_count !=
> +		    old_space->def->field_count)) {
> +			diag_set(ClientError, ER_ALTER_SPACE,
> +				  space_name(old_space),
> +				  "can not modify format or field_count of a "

field_count -> field count

What if field count count is the same, but we modify column's type?

> +				  "view");
> +			return -1;
> +		}
>  		/*
>  		 * Allow change of space properties, but do it
>  		 * in WAL-error-safe mode.
> diff --git a/test/box/view-dont-modify-format.result b/test/box/view-dont-modify-format.result
> new file mode 100644
> index 000000000..c130db49c
> --- /dev/null
> +++ b/test/box/view-dont-modify-format.result

Why not put the test case into sql/view.test.lua?