From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 21B74469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 16 Sep 2020 16:27:10 +0300 (MSK)
Date: Wed, 16 Sep 2020 13:27:09 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200916132708.GB10599@tarantool.org>
References: <20200911215115.6622-1-roman.habibov@tarantool.org>
 <20200911215115.6622-3-roman.habibov@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200911215115.6622-3-roman.habibov@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 2/6] sql: refactor
 create_table_def and parse
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

On 12 Sep 00:51, Roman Khabibov wrote:
> Move ck, fk constraint lists and autoincrement info from
> struct create_table_def to struct Parse to make the code more
> reusable when implementing <ALTER TABLE ADD COLUMN>.
> 
> Needed for #3075
> ---

Does ANSI allow to include constraints in ADD COLUMN statement?
Why did you decide to add autoincrement to this list? Was there any
discussion on this subj?

>  src/box/sql/build.c     | 182 ++++++++++++++++++++++------------------
>  src/box/sql/parse.y     |   2 +
>  src/box/sql/parse_def.h |  53 ++++++------
>  src/box/sql/prepare.c   |   3 +-
>  src/box/sql/sqlInt.h    |  12 +++
>  5 files changed, 142 insertions(+), 110 deletions(-)
>