From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CE067469719 for ; Tue, 15 Sep 2020 18:14:21 +0300 (MSK) Date: Tue, 15 Sep 2020 18:14:20 +0300 From: Kirill Yukhin Message-ID: <20200915151420.6oo4cj7t624szfbt@tarantool.org> References: <889eb7a5993813ac702095413881a8be5480e932.1599042246.git.avtikhon@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <889eb7a5993813ac702095413881a8be5480e932.1599042246.git.avtikhon@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: fix deployment of tagged commits List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko Hello, On 02 сен 13:25, Alexander V. Tikhonov wrote: > Found that tagged commits were not run the deployment gitlab-ci jobs. > To fix it added 'tags' label for deployment and perfomance jobs. Also > found that after the commit tagged it has tag label in format 'x^0' > and all previous commits till the previous tag became to have tags in > format 'x~' like 'x~1' or 'x~2' and etc. So the check > > if git name-rev --name-only --tags --no-undefined HEAD ; then > > became always pass and previous commits on rerun could began to deploy. > To fix it was used gitlab-ci environment variable 'CI_COMMIT_TAG', it > shows in real if the current commit has tag and has to be deployed. > > Part of #3745 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-3745-gitlab-ci-tags > Issue: https://github.com/tarantool/tarantool/issues/3745 I've checked your patch into 1.10, 2.4, 2.5 and master. -- Regards, Kirill Yukhin