From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 71096469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 15 Sep 2020 17:59:22 +0300 (MSK)
Date: Tue, 15 Sep 2020 17:59:21 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200915145921.b3snxw6l7rrps5n2@tarantool.org>
References: <0b53e2f0a0c7a35cfbbfef3a66a68a82147b46ad.1599814524.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0b53e2f0a0c7a35cfbbfef3a66a68a82147b46ad.1599814524.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] test: flaky
	replication/gh-3704-misc-*
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 11 сен 11:56, Alexander V. Tikhonov wrote:
> On heavy loaded hosts found the following issue:
> 
>   [037] --- replication/gh-3704-misc-replica-checks-cluster-id.result	Thu Sep 10 18:05:22 2020
>   [037] +++ replication/gh-3704-misc-replica-checks-cluster-id.reject	Fri Sep 11 11:09:38 2020
>   [037] @@ -25,7 +25,7 @@
>   [037]  ...
>   [037]  box.info.replication[2].downstream.status
>   [037]  ---
>   [037] -- follow
>   [037] +- stopped
>   [037]  ...
>   [037]  -- change master's cluster uuid and check that replica doesn't connect.
>   [037]  test_run:cmd("stop server replica")
> 
> It happened because replication downstream status check occurred too
> early, when it was only in 'stopped' state. To give the replication
> status check routine ability to reach the needed 'follow' state, it
> need to wait for it using test_run:wait_downstream() routine.
> 
> Closes #5293
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5293-fix-3704
> Issue: https://github.com/tarantool/tarantool/issues/5293

I've checked your patch into 2.4, 2.5 and master.

--
Regards, Kirill Yukhin