From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com
 [209.85.167.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 9E3BC469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 14 Sep 2020 13:18:19 +0300 (MSK)
Received: by mail-lf1-f66.google.com with SMTP id y2so12783465lfy.10
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 14 Sep 2020 03:18:19 -0700 (PDT)
Date: Mon, 14 Sep 2020 13:18:16 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200914101816.GB991329@grain>
References: <cover.1599931123.git.v.shpilevoy@tarantool.org>
 <ceb2e76b3e0e4bda72f45ded1351ba0957cf2d6a.1599931123.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ceb2e76b3e0e4bda72f45ded1351ba0957cf2d6a.1599931123.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/4] xlog: introduce an error code
	for XlogGapError
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Sat, Sep 12, 2020 at 07:25:54PM +0200, Vladislav Shpilevoy wrote:
> XlogGapError object didn't have a code in ClientError code space.
> Because of that it was not possible to handle the gap error
> together with client errors in some switch-case statement.
> 
> Now the gap error has a code.
> 
> This is going to be used in applier code to handle XlogGapError
> among other errors using its code instead of RTTI.
> 
> Needed for #5287

And this one too
Acked-by: Cyrill Gorcunov <gorcunov@gmail.com>