From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D6629469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 11 Sep 2020 16:11:47 +0300 (MSK)
Date: Fri, 11 Sep 2020 16:11:46 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200911131146.km2u5d75cyzogcyw@tarantool.org>
References: <20200909081955.45791-1-olegrok@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200909081955.45791-1-olegrok@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] lua: fix panic in case when
 log.cfg.log incorrecly specified
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: olegrok@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 09 сен 11:19, olegrok@tarantool.org wrote:
> From: Oleg Babin <babinoleg@mail.ru>
> 
> This patch makes log.cfg{log = ...} behaviour the same as in
> box.cfg{log = ...} and fixes panic if "log" is incorrectly
> specified. For such purpose we export "say_parse_logger_type"
> function and use for logger type validation and logger type
> parsing.
> 
> Closes #5130
> ---
> Issue: https://github.com/tarantool/tarantool/issues/5130 
> Branch: https://github.com/tarantool/tarantool/tree/olegrok/5130-panic-on-invalid-log

I've checked your patch into 2.5 and master.

--
Regards, Kirill Yukhin